search

pierrepo / PBxplore

A suite of tools to explore protein structures with Protein Blocks :snake:
https://pbxplore.readthedocs.org/en/latest/
MIT License
28 stars 17 forks source link

Fix #148 #149

Closed HubLot closed 7 years ago

HubLot commented 7 years ago

Hi guys,

This is a first draft the solve the issue #148.

I add the optional variable offset in the _slice_matrix() option and I modified only the `plot_map() function.

In PBstat, I also precise the print statement about the index of the first residue (offset) and the lower bound wanted (residue_min).

The modifications are not finalized nor the commit message, it's just a PoC for you to review my solution. If it's ok, I'll clean it and finish the work.

pierrepo commented 7 years ago

OK with the PoC. Maybe residue_first would be better than offset (and comparable to residue_min and residue_max). Do we agree that offset/residue_first must be read from the .PB.count file?

HubLot commented 7 years ago

Yes, it must be read from the count file. I'm okay with residue_first but I'm afraid it could misunderstood with the name of the residue. Maybe idx_first_residue ?

pierrepo commented 7 years ago

ok for idx_first_residue ;-)

HubLot commented 7 years ago

I think it's good :)

pierrepo commented 7 years ago

Nice job. Thanks for the tests!