search

pierrepo / PBxplore

A suite of tools to explore protein structures with Protein Blocks :snake:
https://pbxplore.readthedocs.org/en/latest/
MIT License
28 stars 17 forks source link

Two tests 'xfailed' #167

Closed pierrepo closed 7 years ago

pierrepo commented 7 years ago

By running tests with the last version of PBxplore (after integration of pytest as the new test engine):

import pbxplore
pbxplore.test()

I encountered two xfail tests:

pbxplore/tests/test_regression.py::TestPBAssign::test_different_outputs xfail
pbxplore/tests/test_regression.py::TestPBstat::test_weblogo_logo_invalid_format xfail

These xfailed tests do not seem very problematic since the final return code of the test suite is 0 (i.e. success). @jbarnoud could you have a look?

jbarnoud commented 7 years ago

xfail means that the test is expected to fail; in this case, they even have to fail (they are set to be strict failures). So everything is perfectly normal here.

pierrepo commented 7 years ago

Hence the return code of 0. Thanks for the explanation @jbarnoud.