search

pierrepo / PBxplore

A suite of tools to explore protein structures with Protein Blocks :snake:
https://pbxplore.readthedocs.org/en/latest/
MIT License
28 stars 17 forks source link

PBclust should not have a default number of clusters #45

Closed jbarnoud closed 9 years ago

jbarnoud commented 9 years ago

This may be controversial, but I do not think PBclust should have a default number of clusters. While I understand that it is convenient for beginners to have a minimum of options to care about, I think the number of clusters should be chosen based on the user knowledge of the system and the problem. Having a default value for the number of clusters hides the importance of this choice.

In addition, a default value should make sense in most cases. Yet, in most cases, 5 is not a pertinent number of clusters.

Therefore, I think the clusters argument of PBclust should be mandatory, and should not have a default value.

pierrepo commented 9 years ago

I agree.

alexdb27 commented 9 years ago

I agree with the PBxplore's gods. Default is good.

alexdb27 commented 9 years ago

As it had been tested ?