Logic in selecting worst sample seems flawed

pierreroudier / clhs

A R implementation of the conditioned Latin Hypercube Sampling method

12 stars 9 forks source link

Logic in selecting worst sample seems flawed #16

Closed david-clifford closed 3 years ago

david-clifford commented 3 years ago

I believe the logic for selecting the worst sample is flawed, not fatally though. If the first bin of the average histogram is the furthest from eta it doesn't makes sense to drop the first sample from the subset. I believe I have a fix and if I can figure out github pull requests I'll make one.

david-clifford commented 3 years ago

Figured out pull request but needed to create a new issue. I'm rusty with github. Thanks Pierre.