search

pierresouchay / consul-rust

Rust client libray for Consul HTTP API
Apache License 2.0
92 stars 48 forks source link

Service node #10

Closed mcasper closed 7 years ago

mcasper commented 7 years ago

catalog::get_nodes returns a vector of ServiceNodes, but the struct isn't public, and thus can't be referenced.

mcasper commented 7 years ago

@stusmall bump

stusmall commented 7 years ago

Thanks for the change

stusmall commented 7 years ago

I see you have other changes lined up. I've actually been in the process of completely rewriting this library since it hasn't been in great shape lately. I've based all the new changes off the Go API, so I wouldn't spend too much time working on this current code base. I'll work on getting my refactored changes up sometime this week.

timperrett commented 6 years ago

@stusmall did you ever get to this rewrite? Looking at the PRs i dont see changes in recently, and im on the verge of writing my own client :-)

stusmall commented 6 years ago

Take a look at the branch https://github.com/stusmall/consul-rust/tree/refactor

I'm making my changes there. It should be in much better shape than master. If you make changes and send pull requests towards that branch I'll happily accept them. I'd like to get the refactor branch caught up in features to master before I replace it even if it has less bugs. I can use all the help I can get to catch up.

timperrett commented 6 years ago

@stusmall thanks for the pointer; will check it out and see what i can help with 👍

stusmall commented 6 years ago

And if you have any questions on what to needs work or how things are organized, don't be afraid to reach out.