search

pierresouchay / consul-rust

Rust client libray for Consul HTTP API
Apache License 2.0
92 stars 48 forks source link

Why get_nodes method takes ownership over service name? #13

Closed SkeLLLa closed 4 years ago

SkeLLLa commented 7 years ago

Hello. The question is about method https://github.com/stusmall/consul-rust/blob/9c724a5fea89d3457deaa9a2c5d33bcdcd6f26c0/src/catalog.rs#L40

Why it's taking ownership over service name param instead of just borrowing it?

stusmall commented 7 years ago

It should just borrow it. I'm currently working on completely reworking the whole library. There are multiple issues with it. Check this branch: https://github.com/stusmall/consul-rust/tree/refactor

If the features you need are supported the code is in much better shape.

stusmall commented 4 years ago

This has since been fixed