search

pierresouchay / consul-rust

Rust client libray for Consul HTTP API
Apache License 2.0
92 stars 48 forks source link

KV Value b64 decoder #42

Closed jmcconnell26 closed 3 years ago

jmcconnell26 commented 4 years ago

For after https://github.com/stusmall/consul-rust/pull/40

pierresouchay commented 3 years ago

Hello @jmcconnell26 ... Are you still interested with rebasing this PR? I'll watch it quickly, I promise!

jmcconnell26 commented 3 years ago

Hi @pierresouchay, that should now be good to go!

pierresouchay commented 3 years ago

Hello @jmcconnell26, There are still some conflicts, can you rebase on master?

jmcconnell26 commented 3 years ago

Hi @pierresouchay, where are you seeing the merge conflicts? DeepinScreenshot_select-area_20210428180812

pierresouchay commented 3 years ago

@jmcconnell26 Well... yes! (Ok, that's weird) Capture d’écran 2021-04-28 à 19 25 20

jmcconnell26 commented 3 years ago

Hmmm, interesting Let me put the changes in a new PR

jmcconnell26 commented 3 years ago

@pierresouchay, does https://github.com/pierresouchay/consul-rust/pull/55 look any better?

pierresouchay commented 3 years ago

@jmcconnell26 Yes! indeed! Might be linked to the change the repository path... Can you close the this PR? Thank You!