search

pierresouchay / consul-rust

Rust client libray for Consul HTTP API
Apache License 2.0
92 stars 48 forks source link

async/await support #46

Open ammarzuberi opened 3 years ago

ammarzuberi commented 3 years ago

Hi,

I recently started using consul-rust for a project but found that async support was recently removed: https://github.com/pierresouchay/consul-rust/commit/41d133d8db7eef3f9c59bac9b1e7a333b2e337cc

I implemented an async variation using the existing code, and it is available at https://github.com/ammarzuberi/consul-async. However, I'm not sure of the reason non-blocking reqwest was removed in the first place. I'm also not sure how you'd prefer merging this into consul-rust. Maybe behind a feature flag or by splitting blocking/non-blocking equivalents into separate modules?

Let me know and I'll do the work to get it into the crate.

pierresouchay commented 3 years ago

Hello @ammarzuberi ,

Yes, I am interested in merging such support in this version. I am sorry, I could not work on the project for a while, but I would like to give it a second chance, so fell free to try a PR, I'll have a look.

Thank you!

Regards

colin-grapl commented 3 years ago

https://github.com/colin-grapl/consul-rust

I've got a fork here that adds support, updates the tests and readme. If you have a good way for me to run integration tests I'd be happy to verify that they pass.