Adding in logic to deserialize kv value from b64 encoded string

pierresouchay / consul-rust

Rust client libray for Consul HTTP API

Apache License 2.0

93 stars 48 forks source link

Adding in logic to deserialize kv value from b64 encoded string #60

Closed tomers closed 3 years ago

tomers commented 3 years ago

Adding custom deserializer for KVPair value field
Updating tests to reflect change

This is a rebase of PR #55 by @jmcconnell26

tomers commented 3 years ago

@pierresouchay I guess this is a breaking change API wise, so it would require a major version update.

pierresouchay commented 3 years ago

Hello @tomers ,

Thanks a lot for all your submissions (feel to to add yourself in the authors manifest for the project), but as explained here: https://github.com/pierresouchay/consul-rust/pull/55#pullrequestreview-647578537, I have an issue with the approach as it would fail on binary data, so assuming the data is utf8 is IMHO a mistake.

I am completely for another way of doing it however and having helpers to extract it (and it might avoid breaking the API as well)

tomers commented 3 years ago

No problem :-) I see that @jmcconnell26 (original author) responded and said he'll work on #55, so there's no point in this PR (besides some Clippy fixes). Closing it for now.