pierresouchay / consul-rust

Rust client libray for Consul HTTP API
Apache License 2.0
92 stars 48 forks source link

implement agent service register & deregister. fix request parse json error #63

Open uxgnaw opened 3 years ago

pierresouchay commented 3 years ago

Hello @uxgnaw ,

Thanks a lot for the contribution. There are a few issues however:

Some of the fields are Optional:

I also think we probably need one structure for registration and another for read as the semantics are sometimes a bit different.

We also have to deal with token to allow registration of such service since several tokens might be required depending of the service being registered as well as handling checks (you can ignore Check alone and handle only Checks)

I also activated the CI, so now, you'll have the CI running

Kind Regards

uxgnaw commented 3 years ago

i agree with you. it's not 100% implement. we can have features fisrt. this is work for my situation