search

pierrotsmnrd / grabKit

Drop-in iOS component to easily import photos from Facebook, FlickR, Instagram, Picasa, and more
Other
396 stars 89 forks source link

iphone/device Picker issue: Some photos are not selectable #27

Closed clientmedia closed 11 years ago

clientmedia commented 11 years ago

I am testing with iPhone 4 + ios6 and on albums with more than 1 page, picker will not select some photos. ie. Tap on some photos does not show the selection check.

Seems to be working fine for remote sources.

Thanks

pierrotsmnrd commented 11 years ago

Are the photos already loaded when you try to select them ?

clientmedia commented 11 years ago

Yes, the photos are loaded and thumbs displayed in the grid. Its happens with bigger albums. I can select most but random thumbs are not selected as if tap was not recognized. Tested with ios 6 on iphone 4

On Fri, May 17, 2013 at 10:52 PM, Pierre-Olivier Simonard < notifications@github.com> wrote:

Are the photos already loaded when you try to select them ?

— Reply to this email directly or view it on GitHubhttps://github.com/pierrotsmnrd/grabKit/issues/27#issuecomment-18095671 .

pierrotsmnrd commented 11 years ago

Ok, I'm investigating. If you find any way to reproduce this bug on demand, let me know.

clientmedia commented 11 years ago

Did some basic testing to reproduce.

On any Album with > 30 photos, I can't select photo 29,30,31,32. Photo 33 is selectable. After that random photos are selectable. Tested for phone and facebook as source.

Weird that I can't see the same behavior on the 5.1 or 6.0 simulator. Only on the device. Running on iphone 4 with OS 6.1

Thanks

On Sat, May 18, 2013 at 12:26 AM, Pierre-Olivier Simonard < notifications@github.com> wrote:

Ok, I'm investigating. If you find any way to reproduce this bug on demand, let me know.

— Reply to this email directly or view it on GitHubhttps://github.com/pierrotsmnrd/grabKit/issues/27#issuecomment-18096506 .

pierrotsmnrd commented 11 years ago

I found the origin of the bug : in GRKPickerPhotosListThumbnail.m, in the method prepareForReuse, I forgot to add " self.selected = NO; " So, when reusing a thumbnail, if it was previously selected, the new thumbnail was considered as already selected.

4d5328ff8c380965d4eb25e9c7d2d7d1ae38ad1b