search

piersharding / moodle-tool_uploadcoursecategory

Moodle Admin Tools plugin for basic upload of course categories
23 stars 13 forks source link

Fixes coding styles for Moodle 4 #10

Closed oliviervalentin closed 5 months ago

oliviervalentin commented 5 months ago

In a recent discussion (https://moodle.org/mod/forum/discuss.php?d=456843), some Moodle users were asking for an update of your plugin Upload Course Category. As I read in this post, you are no longer working on Moodle, and have no time to do this...

If you are ok, I'm pushing you an update for Moodle 4, integrating recents recommandations of coding styles, so that people can still use you very useful plugin ! It has been tested by several persons and works perfecly. As I said, I didn't changed anything to features, just keeping to maintain coding styles.

If you totally want to abandon it, please consider to offer it to community by searching for another maintainer : https://moodledev.io/general/community/plugincontribution/adoption

Best regards, Olivier

piersharding commented 5 months ago

thanks for doing this.

oliviervalentin commented 5 months ago

Thank you very much ! Do you think you could push new version on Moodle's plugins repository ?

bfriesenvcc commented 5 months ago

@oliviervalentin , I'm not sure about how it should work, as I am not a developer, but... since this plugin has never been uploaded into the Moodle plugins repository, and @piersharding has given the blessing for someone else to take it over, I wouldn't think it would need to go through the adoptions programme, would it?

If you were willing to be the maintainer (hint, hint) then you could just add it to the plugins repository and go from there, no?

I think @piersharding would support this (especially if he still receives a mention as the original developer).

oliviervalentin commented 5 months ago

@bfriesenvcc : thank you for your message !

Indeed, this plugin is not referenced in Moodle's plugin directory ! My bad, I just answered to a friend's asking for updating this plugin, but I didn't searched if it was registered...

Now, I'm asking myself if it should be... @piersharding opened me his plugin repository for updates, maybe we should stay like this. That would be more honest, instead of creating a plugin entry with my name, while I didn't created it and I'm juste maintainer (though I don't know if I would be able to do it correctly ! :) ).

Olivier

piersharding commented 5 months ago

Hi @oliviervalentin - thanks for looking into this. I'm quite happy for you to take over the project, it is entirely up to you for how you want to do that and what suites you best. Cheers, Piers.