Attempt to fix issue #341

pierucci / heemod

:chart_with_upwards_trend:Markov Models for Health Economic Evaluations

https://pierucci.org/heemod/

Other

41 stars 25 forks source link

Attempt to fix issue #341 #342

Closed jriley-dhsc closed 4 years ago

jriley-dhsc commented 4 years ago

As per https://github.com/pierucci/heemod/issues/341 the message when look_up encounters missing values makes a bit more sense.

I've not done many PRs on other people's projects, so let me know if I've done anything wrong.

I'm not sure if I've introduced new dependencies for the project, if so then I can rewrite some bits.

KZARCA commented 4 years ago

Hi! Thank you! Dependencies of heemod are : dplyr ggplot2 lazyeval memoise mvnfast plyr pry tibble rlang Could you please add a test and update the NEWS file? Best

jriley-dhsc commented 4 years ago

Is that hitting "build package" in Rstudio, and updating news.md? Apologies, I'm not very familiar with pacakge development.

KZARCA commented 4 years ago

Thanks, I slightly modified your code and added tests. Best

jriley-dhsc commented 4 years ago

Thank you very much!