pieterlange / kube-openvpn

:closed_lock_with_key: Kubernetes native OpenVPN
MIT License
383 stars 57 forks source link

Moving deploy.sh into image #33

Closed cemo closed 7 years ago

cemo commented 7 years ago

The current way of deploying openvpn is that cloning project and running commands. If deploy.sh would be moved into the image, there will be no need to clone project. This is might be considered as a temporary improvement before moving into a chart.

pieterlange commented 7 years ago

I want the image itself to stay as barebones as possible so i don't think i'll do this.

cemo commented 7 years ago

The problem is that cloning repo is tedious and error-prone. Using commands would be cooler. Given the fact that this image is providing k8s related implementation, having a file producing necessary manifests is not problem.

This also makes more consistent across repo and other commands. Repo or image might be outdated. In case such an inconsistency might create a problem.

pieterlange commented 7 years ago

I'm re-evaluating openvpn PKI initialization and will take your comments into account. I will not cover this proposed workflow however. (temporary stuff tends to stay forever)