search

pieterlexis / swede

A tool to create and verify TLSA (DANE) records
54 stars 11 forks source link

SNI is not used for usage 3 #20

Closed tribut closed 7 years ago

tribut commented 7 years ago

When using -u 3 SNI is not used, even if available. This leads to the wrong certificate being used for verification and generation. There is an explicit check for this in two lines of code:

https://github.com/pieterlexis/swede/blob/master/swede#L637 https://github.com/pieterlexis/swede/blob/master/swede#L777

Maybe I simply don't "get" what this is supposed to do, but I guess they should just be removed?

pieterlexis commented 7 years ago

it has been a long time since I wrote or looked at this code. I'll see what I can do

tribut commented 7 years ago

I've created a PR to remove the check for usage == 3 as suggested and it works for me, but again: I do not understand why this check was ever there so ymmv.

pieterlexis commented 7 years ago

I have no clue either, years-ago-me's answer is lost to history :) Thanks!

tribut commented 7 years ago

😄