search

pietermartin / sqlg

TinkerPop graph over sql
MIT License
245 stars 51 forks source link

Seperation of datasource, test cases #190

Closed pietermartin closed 2 years ago

pietermartin commented 7 years ago

Most of this work is done in https://github.com/pietermartin/sqlg/pull/165

The postgres batch code still has references to c3p0.

We need some test cases with a different datasource.

pietermartin commented 7 years ago

Some batch tests are failing after #195 with ClassCastException The connection needs to unwrapped first to get the postgres jdbc driver's CopyManager I am on it.

pietermartin commented 7 years ago

Fixed it with https://github.com/pietermartin/sqlg/commit/e0fea4d505ad93722700d7b56768b91286326840

Running the tests to see all is well.

pietermartin commented 7 years ago

At the moment the C3P0 pool's dependency is in core. This means that people using a different pool still carry the C3P0 dependency. Need to extract the dependency into a different maven module.