search

pietermartin / sqlg

TinkerPop graph over sql
MIT License
243 stars 51 forks source link

change `TIME WITH TIME ZONE` To `TIME` #396

Closed pietermartin closed 3 years ago

pietermartin commented 3 years ago

For some reason day light saving turns a +2 UTC offset into a +1 UTC offset in postgresql. Yet casting a literal to 'xx:xx:xx'::TIME WITH TIME ZONE has the +2 and thus there is a mismatch on querying from java.

Besides, from postgresql's docs "We do not recommend using the type time with time zone (though it is supported by PostgreSQL for legacy applications and for compliance with the SQL standard)"

The other databases also needs investigation.

pietermartin commented 3 years ago

Ok time to remove all timezone datatypes. Sqlg never needed nor used the database timezone features. This will however require upgrade scripts to be run to alter the column's type.

pietermartin commented 3 years ago

Done, added a check on startup to check for columns with timestamptz. If there are any an exception is thrown