search

pietermartin / sqlg

TinkerPop graph over sql
MIT License
244 stars 51 forks source link

`TopologyListener` needs `beforeCommit` parameter #492

Closed pietermartin closed 1 year ago

pietermartin commented 1 year ago

TopologyListener.change(TopologyInf topologyInf, TopologyInf oldValue, TopologyChangeAction action) fires after the transcation commited when firing in the Topology.fromNotifyJson. This lets a different SqlgGraph know about changes that has happened. However listeners in the same jvm receive the event before the transaction has committed. The change signature needs a boolean to indicate before or after commit.

pietermartin commented 1 year ago

TopologyChangeAction need RENAME action

pietermartin commented 1 year ago

Not adding RENAME action as rename is handled as a delete and create via the distributed notification mechanism