search

pietermartin / sqlg

TinkerPop graph over sql
MIT License
246 stars 51 forks source link

MySql and MariaDb support #511

Closed dezmaeth closed 3 months ago

dezmaeth commented 4 months ago

Hi @pietermartin,

Firstly, thank you for your incredible work on SQLG. It's a fantastic tool, and its versatility is highly appreciated within the community.

I understand that support for MySQL and MariaDB was removed in the latest version due to time constraints. These databases are widely used, and their support is crucial for many of us.

I would like to offer help reintroduce MySQL and MariaDB compatibility to SQLG. I believe that with collaboration, we can restore this functionality and continue to improve the utility and reach of SQLG.

Please let me know how best I can assist with this. I am open to contributing through a pull request or collaborating in any other way that suits the project's needs. Your guidance and direction on how to proceed will be greatly appreciated.

Looking forward to your response.

Best regards,

pietermartin commented 4 months ago

Hi, sorry for the late reply, I am traveling at the moment.

Thanks for the offer to help restore MySQL and MariaDB. I am back in August and will contact you to see how we can collaborate on maintaining and improving the MySQL and MariaDB dialects.

Regards Pieter

pietermartin commented 3 months ago

I added back support for mariadb and mysql. @dezmaeth can you check this on your environment please.

Sqlg's tests are passing. Need to think of a way to execute TinkerPop's feature test suit. It requires multiple dbs which is not possible on mariadb/mysql without running multiple servers.

The work is on the mariadb_mysql branch.

pietermartin commented 3 months ago

MariaDB and Mysql passes the test suites.

dezmaeth commented 3 months ago

awesome, i'll check it!

pietermartin commented 3 months ago

Merged this into master. Closing the issue for now. Please create new issues for any specific issues that arise.