Closed survivor303 closed 4 years ago
Good point, should just be a matter of changing the permissions i think. I'll give it a try when i'm back from my holiday.
Ok so I nearly got it working, but i don't know if its a great idea to annoy 5000+ users with this popup:
Which is generated by chrome because I need to change the permissions of the extension.
Besides, i doubt many people will use the feature, as most mobile users probably use youtube via the youtube app.
we who dont support youtube ads or want a working background play, uses firefox mobile for it :)
I say yes for this change to happen :100:
Not sure if you ended up doing it anyway, but I just wanted to let you know that optional permissions are a thing.
https://developer.chrome.com/extensions/permissions
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/contentScripts/register
Firefox and Chrome use different APIs for this sadly.
Here is my implementation in SponsorBlock: https://github.com/ajayyy/SponsorBlock/blob/master/src/utils.ts#L54
Background page code: https://github.com/ajayyy/SponsorBlock/blob/f33fa2f621034bcc2f93333b7f5e455fa7cf6d5c/src/background.ts#L108 (Firefox requires that it is executed on the background page every time the extension is reloaded)
You should be able to copy-paste those helper functions. I'll grant access to this code under MIT license if you need it (Since the project is GPL).
Not sure if you ended up doing it anyway, but I just wanted to let you know that optional permissions are a thing.
https://developer.chrome.com/extensions/permissions
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/contentScripts/register
Firefox and Chrome use different APIs for this sadly.
Here is my implementation in SponsorBlock: https://github.com/ajayyy/SponsorBlock/blob/master/src/utils.ts#L54
Background page code: https://github.com/ajayyy/SponsorBlock/blob/f33fa2f621034bcc2f93333b7f5e455fa7cf6d5c/src/background.ts#L108 (Firefox requires that it is executed on the background page every time the extension is reloaded)
You should be able to copy-paste those helper functions. I'll grant access to this code under MIT license if you need it (Since the project is GPL).
Thanks for letting me know! I think i'll just take the easy route and add m.youtube.com to the permissions, then I can finally close this nearly year old issue 😅
Just submitted version 0.2 with m.youtube.com support. Let me know if it breaks.
Please add support m.youtube.com. For now, thumbnails dosnt update on mobile site.