search

pietervanheijningen / clickbait-remover-for-youtube

Replaces thumbnails and modifies titles of videos on youtube.com
https://chrome.google.com/webstore/detail/clickbait-remover-for-you/omoinegiohhgbikclijaniebjpkeopip
MIT License
354 stars 21 forks source link

Added French and Arabic translation #55

Closed macro010 closed 1 year ago

macro010 commented 1 year ago

Added two folders in "_locales" AR and FR, each containing a .json file with proper langue translation.

pietervanheijningen commented 1 year ago

I'm going to remove the "M" in the middleOfTheVideo arabic translation, I assume this was a mistake. Other than that, seems fine. Thank you very much!

pietervanheijningen commented 1 year ago

Oh yeah, and I was not able to test it, I tried changing my chrome language to arabic, but it did not work. Hope it will work fine :D. Should do, the other languages work

macro010 commented 1 year ago

Hey!!

Sorry for the late reply, about Arabic it's a known issue same as Chinese. As far as i know it has something to do with how utf or encoding in general. It was my pleasure to add something and i am happy go hear the other languages are working just fine.

Good luch and best regards.

On Fri, Apr 14, 2023, 8:55 a.m. pietervanheijningen < @.***> wrote:

Oh yeah, and I was not able to test it, I tried changing my chrome language to arabic, but it did not work. Hope it will work fine :D. Should do, the other languages work

— Reply to this email directly, view it on GitHub https://github.com/pietervanheijningen/clickbait-remover-for-youtube/pull/55#issuecomment-1508172217, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOGZBQFLO4TQ7TEKPFEP6STXBEGJ3ANCNFSM6AAAAAAWXXEWFU . You are receiving this because you authored the thread.Message ID: <pietervanheijningen/clickbait-remover-for-youtube/pull/55/c1508172217@ github.com>

pietervanheijningen commented 1 year ago

Good to know that it works! Thanks again :)