pietervdvn / MapComplete

An easy-to-use webapp to edit OpenStreetMap
https://mapcomplete.org
194 stars 89 forks source link

Studio: how to disable Adding Data? #1924

Closed tordans closed 2 months ago

tordans commented 2 months ago

I have "enableAddNewPoints": false in my Studio theme but I still see the "Add object" button and "Zoom in to add object" notice.

Example: https://mapcomplete.org/theme.html?z=17.6&lat=52.47748441461101&lon=13.440496252114144&userlayout=https%3A%2F%2Fstudio.mapcomplete.org%2F11881%2Fthemes%2Fberlin_emergency_water_pumps%2Fberlin_emergency_water_pumps.json#

Theme 11881 JSON

``` { "id": "berlin_emergency_water_pumps", "startLat": 50.8465573, "startLon": 4.351697, "startZoom": 16, "title": { "en": "Berlin Water Wells", "de": "Berliner Pumpen" }, "description": { "en": "This map shows the location and operational state of berlin water wells (pumps).
Please sende feedback to alex@osm-berlin.org. You can use this map to update the operational state of each pump and add/update a check date.", "de": "Die Karte zeigt die Funktionsfähigkeit und Position der Berliner Straßenbrunnen.
Feedback gerne an alex@osm-berlin.org.

  • Die Icons zeigen den Typ des Brunnen im Scherenschnitt.
  • Das Zusatz-Icon zeigt den Funktionsstatus (Funktionstüchtig, Defekt, Abgeschlossen, Unbekannt)
  • Der Text zeigt das Datum der letzten Funktionsprüfung bzw. den Hinweis, wenn diese durchgeführt werden sollte.
" }, "icon": "./assets/themes/drinking_water/logo.svg", "layers": [ "https://studio.mapcomplete.org/11881/layers/berlin_emergency_water_pump_layer_v2/berlin_emergency_water_pump_layer_v2.json" ], "enableUserBadge": true, "enableShareScreen": true, "enableMoreQuests": false, "enableLayers": false, "enableSearch": true, "enableAddNewPoints": false, "enableGeolocation": true, "enableBackgroundLayerSelection": true, "enableShowAllQuestions": true, "enableDownload": true, "enablePdfDownload": true, "enableNoteImports": false, "enableTerrain": false } ```

tordans commented 2 months ago

Maybe the way to do is different and I have to remove the Preset to remove the button?

However, what is enableAddNewPoints": false used for in this case?

image
pietervdvn commented 2 months ago

This feature switch is mostly meant to be used either as query parameter (e.g. in an iframe where adding new points must be disabled) or to be used when a theme uses several layers which have a preset. In either case, it is seldomly used.

pietervdvn commented 2 months ago

I've re-enabled it.