pietervdvn / MapComplete

An easy-to-use webapp to edit OpenStreetMap
https://mapcomplete.org
212 stars 92 forks source link

Attempting upload loops due to changed API #2099

Closed davidpnewton closed 5 days ago

davidpnewton commented 2 weeks ago

A bug of some kind appears to have been introduced with the trees theme. Previously it would sometimes hold rapid-fire edits in a queue and then upload them together as one changeset, as the other themes do.

Since yesterday it has started looping when attempting uploads. It will change the message from awaiting upload to the uploading one and then back without actually doing anything on the OSM servers.

OSM changeset 15779390 only finally uploaded after I changed to the streetlights theme and triggered changeset 15782638.

I have tried doing this both in Chrome on Android and Chrome on Windows. I have also tried reauthorising the OAuth token in case something was going on with that. Neither stopped the looping.

I don't know if this a more general issue but so far I have only encountered it when using the trees theme.

PeterBrodersen commented 2 weeks ago

I experience the same thing with the Etymology theme on Firefox for Windows, also since yesterday. Curiously it seems to work better in Chrome for Windows here.

pietervdvn commented 2 weeks ago

Hi, this is related to https://github.com/openstreetmap/openstreetmap-website/issues/5047

Please, force-update MapComplete by pressing Ctrl+F5, long pressing the "reload-icon" or using 'clear caches' in settings.

Another option is to open a map you've never opened before. This will load the latest version and upload your pending changes

davidpnewton commented 2 weeks ago

That would appear to explain this as well:

Screenshot_20240828_082444_Chrome

I'll try and make sure to force update things on Android as well as Windows. I'll let you know if any issues persist.

davidpnewton commented 2 weeks ago

Still having problems with caching of content on Android. The trees theme is stuck at 0 44.8 and of course there's no CTRL + F5 on Android to force a cache flush.

However I have found a workaround: switch to a different theme that isn't caching an out of date version and then it proceeds to upload. So doing that I get themes at 0.45.7 and can successfully upload changesets.

pietervdvn commented 2 weeks ago

Right, visiting a theme you haven't visited before is a good way to upload.

Afterwards, you can clear the sites cache and data to force an update.

Note: I've made caching less aggressive in newer versions so that this becomes easier

davidpnewton commented 1 week ago

The trees theme on my Android device has decided to update itself to 0.46.0. I think therefore it's very likely anyone affected by the caching on Android will either have seen it resolve itself by now or this will happen imminently

pietervdvn commented 1 week ago

Yeah, I can see this in the number of reports as well:

date reported errors
2024_8_26.lines.json 8007
2024_8_27.lines.json 3919
2024_8_28.lines.json 3555
2024_8_29.lines.json 2944
2024_8_30.lines.json 4537
2024_8_31.lines.json 1974
2024_9_1.lines.json 5160
2024_9_2.lines.json 847
2024_9_3.lines.json 249
pietervdvn commented 5 days ago

Seems like all clients have updated by now