Closed andreamattavelli closed 6 years ago
Personally I don't like very much uber jars. Since the only external dependence is Javassist I don't see a compelling reason to create an uber jar.
Yes, there is just one external dependency. However, whoever wants to use JBSE has to compile and package it (Maven resolves the javassist dependency) and then retrieve javassist (again) to run the tool. With this patch, the manual resolution of the dependency is not necessary anymore. One can thus package JBSE and use it straight away. I agree that it is not extremely important, but it is in my opinion a valuable addition.
OK, but I would prefer that jbse-<VERSION>.jar
were the original jar, and that the uber jar had name jbse-uber-<VERSION>.jar
. Is it possible?
I don't know if you can rename both jars, but I am confident that we can rename the uber jar. I'll take a look.
Using tag <finalName>
it is possible to specify a custom name. For consistency with Maven I decided to use <finalName>${project.artifactId}-shaded-${project.version}</finalName>
, instead of <finalName>${project.artifactId}-uber-${project.version}</finalName>
, but it is a minor point.
The original jar doesn't get renamed, as you wanted.
Great, ack.
The uber jar (
jbse-0.8.0-SNAPSHOT.jar
) is placed in/target
together with the original one (original-jbse-0.8.0-SNAPSHOT.jar
). The uber jar renamesjavassist
asjbse.javassist
to avoid potential conflict during analysis.The jar is built during
package
.