Closed pietrocaselani closed 5 years ago
Merging #196 into master will increase coverage by
4.16%
. The diff coverage is6.62%
.
@@ Coverage Diff @@
## master #196 +/- ##
==========================================
+ Coverage 30.38% 34.54% +4.16%
==========================================
Files 291 292 +1
Lines 6468 7292 +824
==========================================
+ Hits 1965 2519 +554
- Misses 4503 4773 +270
Impacted Files | Coverage Δ | |
---|---|---|
TraktSwift/Models/SearchResult.swift | 0% <ø> (-100%) |
:arrow_down: |
...kerCore/Shows/Progress/ShowProgressViewState.swift | 100% <ø> (+16.66%) |
:arrow_up: |
TraktSwift/Models/Sync/HistoryParameters.swift | 0% <ø> (ø) |
:arrow_up: |
TraktSwift/Models/Show/Show.swift | 0% <0%> (-100%) |
:arrow_down: |
TraktSwift/Models/Show/SeasonIds.swift | 0% <0%> (-79.42%) |
:arrow_down: |
...p/Shows/Progress/ShowsProgressViewController.swift | 38.58% <0%> (+38.58%) |
:arrow_up: |
TraktSwiftTests/ShowsTest.swift | 0% <0%> (ø) |
:arrow_up: |
TraktSwift/Models/Base/BaseEpisode.swift | 0% <0%> (ø) |
:arrow_up: |
TraktSwift/Models/Show/Episode.swift | 0% <0%> (ø) |
:arrow_up: |
TraktSwift/Models/Base/BaseTrendingEntity.swift | 0% <0%> (-100%) |
:arrow_down: |
... and 230 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 752f774...a9917b2. Read the comment docs.
🎉
Tuist is a tool to manage Xcode projects very similar to SPM, but works for iOS projects!
Since this project has more than a few frameworks, I think Tuist will help avoid conflicts on the
CouchTracker.xcodeproj/project.pbxproj
file and manage the dependencies between the frameworks.Now the project configuration lives on the file
Project.swift
, located at root of the project. It's already a big file, but I will try to figure out a better way to keep things organized.Right now, there are still some things that need to be done
Skipping duplicate build file in Copy Bundle Resources build phase: /Users/distiller/project/CouchTrackerCore/Resources/en.lproj/CouchTrackerCore.strings (in target 'CouchTrackerCore')
)About the duplicated strings resources -> https://github.com/tuist/tuist/issues/361