pietrop / digital-paper-edit-client

Work in progress -digital paper edit project - React Client
https://pietropassarelli.com/digital-paper-edit-client/
Other
13 stars 5 forks source link

Performance issue when loading transcript in paper edit #14

Open pietrop opened 4 years ago

pietrop commented 4 years ago

There's a performance issue when loading transcript in paper edit.

The current way of adding highlights is very process intense and triggers the debugger coz it's running out of memory when used in Adobe CEP Panel.

Screen Shot 2020-02-18 at 10 32 10 AM

Raising it here as opposed to the DPE Adobe CEP Panel repo, coz it has to be addressed in the React component that does the highlights interpolation in the transcription's text

pietrop commented 4 years ago

one workaround while finding a solution, might be to disable the highlights feature as a way to do a working release. and then re-introduce it once performance has been fixed.

pietrop commented 4 years ago

Adding a delay so that it adds the transcripts with the highlights after the components is mounted see this commit for details https://github.com/pietrop/digital-paper-edit-client/commit/fbb5b61941462282bada933152c03c6cc31e4789

Tested in adobe CEP, still a bit sluggish but at least the page loads...

Screen Shot 2020-02-18 at 4 43 27 PM

pietrop commented 4 years ago

while I can figure out a better way to avoid for the transcript / annotation interpolation to take up soo much memory, I added a btn to delay the process, and do them one at a time as a workaround when working with Adobe CEP

Screen Shot 2020-02-19 at 4 40 51 PM

pietrop commented 4 years ago

Should test this after having added code splitting

pietrop commented 3 years ago

https://github.com/pietrop/digital-paper-edit-cep/pull/2