pietrop / digital-paper-edit-client

Work in progress -digital paper edit project - React Client
https://pietropassarelli.com/digital-paper-edit-client/
Other
13 stars 5 forks source link

add lazy loading #47

Closed pietrop closed 4 years ago

pietrop commented 4 years ago

bbc/digital-paper-edit-firebase is using React lazy loading

Screenshot 2020-05-21 at 14 22 56

this removes the btn to load transcripts

as well as Route-based code splitting

for loading indications could use skeleton, see docs and installation instructions

pietrop commented 4 years ago

skeleton

pietrop commented 4 years ago

done in https://github.com/pietrop/digital-paper-edit-client/commit/81a3068ad49f3b924ff8b73d679605cdb7ba7702 (and some of previous commits)

pietrop commented 4 years ago

Brought back load transcript btn. Coz lazy loading only optimized performance on initial load and first time around a component is used. Subsequent uses, was actually taking longer to load paper edit view. Might need different type of optimization in the tab.