search

pietrop / subtitlesComposer-app

A simple os x desktop app built in electron, using Aeneas under the hood to generate captions files from media(audio or video) and plain text transcriptions without time-codes.
https://autoedit.gitbook.io/subtitles-composer-app/
Creative Commons Zero v1.0 Universal
30 stars 4 forks source link

Fixed trim function and home path #4

Closed GregoryWullimann closed 5 years ago

GregoryWullimann commented 5 years ago

Hi,

Upon request of Michele Gianella I've made a couple of fixes in order to make the AppImage work well on Unix. I'm unsure if these problem were also on other platforms.

First change was that the trim() function was applied to an array an not to a String, this lead to the complete crash of the AppImage.

The second change is that, from my understanding, AppImage can't modify files that are not in the home of the user. So instead of creating the file in appPath+"/src/tmp/segmentedtext.tmp.txt", the file is now created in ~/tmp/segmentedtext.tmp.txt.

pietrop commented 5 years ago

Looks good! Thanks for this @GregoryWullimann

Just tested it (on Mac) and seems to work great,

Screen Shot 2019-03-26 at 18 41 50

I am guessing you have tested on Linux? (I haven't got a Linux machine to test it on)

GregoryWullimann commented 5 years ago

I am guessing you have tested on Linux? (I haven't got a Linux machine to test it on)

Yes, tested with Elementary OS 5.0!