nbJs Maintainance - Githubissues

pietroppeter / nimib

nimib 🐳 - nim 👑 driven ⛵ publishing ✍

https://pietroppeter.github.io/nimib/

MIT License

175 stars 10 forks source link

nbJs Maintainance #125

Closed HugoGranstrom closed 1 year ago

HugoGranstrom commented 1 year ago

Fixes #122, ~~118~~, #124, #127

[x] Separate untyped and string versions of nbCodeToJs (the body doesn't have to be type-checked anymore)
[x] Rename nbCodeToJs to nbJsFromCode and nbJsFromString
[x] Respect {.exportc.} when mangling names
[ ] ~~Use separate mangling table for each script~~
[x] nbKaraxCode postRender template

HugoGranstrom commented 1 year ago

It took a while but most of the things are done now. The problem of interlaced code blocks I will leave for a later PR as I'm not sure how to solve it best yet.

pietroppeter commented 1 year ago

so basically this was ready some time ago but now it seems really ready :) should I give a quick review and merge?

HugoGranstrom commented 1 year ago

Haha yes :) That would be appreciated, the most important thing being if I named everything new sensibly

pietroppeter commented 1 year ago

as discussed in zoom call, we should add deprecation messages

HugoGranstrom commented 1 year ago

I think this was what we agreed on. Correct if I'm wrong :)