Change toml lib + fix macro bug on devel

pietroppeter / nimib

nimib 🐳 - nim 👑 driven ⛵ publishing ✍

https://pietroppeter.github.io/nimib/

MIT License

175 stars 10 forks source link

Change toml lib + fix macro bug on devel #173

Closed HugoGranstrom closed 1 year ago

HugoGranstrom commented 1 year ago

Fixes the orc bug on #169
Changes the toml parsing library to parsetoml which should make nimib run on orc finally. I had to do some workarounds though, like making my own customToJson proc to get the correct JSON for std / json to be able to parse it correctly into a NbConfig.

pietroppeter commented 1 year ago

Looks great, thanks! And loadTomlSection will be used by nimibook (see https://github.com/pietroppeter/nimibook/blob/main/src/nimibook/configs.nim, I will make the changes).

It is all here right? Does this work with devel now? We can merge this and then rebase the CI Pr on the new master, correct?

HugoGranstrom commented 1 year ago

I found one bug that the stdlib doesn't like missing fields, so I opted for using jsony instead for the deserialization. But now it should be ready to go if the CI is green. I have tried it locally with devel and the configuration is loaded without any error. So we can merge this and see if the CI PR works with it :)

pietroppeter commented 1 year ago

good yeah, I imagined jsony would be a better fit being a loose parser. looks good, merging and rebasing CI since I am curious to see it green (then I will also add a changelog for this)