search

pietroppeter / nimib

nimib 🐳 - nim 👑 driven ⛵ publishing ✍
https://pietroppeter.github.io/nimib/
MIT License
175 stars 10 forks source link

Add `nbCodeSkip` and `allblocks.nim` #187

Closed neroist closed 1 year ago

neroist commented 1 year ago

Add nbCodeSkip from #183

neroist commented 1 year ago

On the same fork I also added nbCapture (branch nb-capture), but I want to add a pull request for that after this one has been merged.

HugoGranstrom commented 1 year ago

First and foremost, thank you so much for contributing to nimib! :smile: It was a pleasant surprise to see a PR from a new face.

As for the code it looks good, the only thing missing (as per the CONTRIBUTING.md) is to

pietroppeter commented 1 year ago

Showcase it somewhere in the documentation. Not sure exactly where though, we are open to suggestions. Maybe we can create a new document that is simply called showcase.nim where we drop showcases of blocks?

Yep I think we should have something like that. I propose an allblocks.nim document where we have a brief description and example for all blocks. In this PR you could add just an example for this single block and we will have a separate issue/PR to populate it with the rest of blocks and think how we can structure that better

pietroppeter commented 1 year ago

And for the scope of this PR Even a code comment on the PR conversation with description and usage of the block would be fine for me.

Thanks a lot for this @neroist and also very happy for you showing up here!

HugoGranstrom commented 1 year ago

Awesome! If you are happy with this PR I'm ready to merge it :D

neroist commented 1 year ago

Okay, I'm happy with it! It's okay to merge.

HugoGranstrom commented 1 year ago

Once again thank you for your contribution. And I'm looking forward to your next PR ;)