search

pietroppeter / nimib

nimib 🐳 - nim 👑 driven ⛵ publishing ✍
https://pietroppeter.github.io/nimib/
MIT License
181 stars 10 forks source link

Make "figure:" not show up when using nbImage with no caption #192

Closed neroist closed 1 year ago

neroist commented 1 year ago

Also added a test.

pietroppeter commented 1 year ago

good point! I checked to see if the image syntax with empty square brackets is valid and for github it is so looks good to me. btw I just realized that the stuff in empty square brackets should actually be alt text instead of caption but I guess for the moment it is not worth to adjust that.

HugoGranstrom commented 1 year ago

It's worth opening an issue on alt-text though so we don't forget it.

Otherwise this looks good to me 👍

pietroppeter commented 1 year ago

It's worth opening an issue on alt-text though so we don't forget it.

opened issue #193