search

pietroppeter / nimib

nimib 🐳 - nim 👑 driven ⛵ publishing ✍
https://pietroppeter.github.io/nimib/
MIT License
181 stars 10 forks source link

Fix `getNimibVersion()` #196

Closed neroist closed 1 year ago

neroist commented 1 year ago

Forgot that nimble doesn't include the src dir, so you'd have to only call parentDir twice.

HugoGranstrom commented 1 year ago

Would it be possible to write a test for this? Just checking that it is a SemVer version or even just that it contains one or two ..

neroist commented 1 year ago

Sure, added!

pietroppeter commented 1 year ago

sorry closed by mistake. Thanks for this! I guess you noticed when trying to deploy https://neroist.github.io/nimitheme/ ? I see it is working fine the meta tag with nimib version now, so I would assume it is already making use of the fix.