pietroppeter / nimib

nimib 🐳 - nim 👑 driven ⛵ publishing ✍
https://pietroppeter.github.io/nimib/
MIT License
175 stars 10 forks source link

Add nbFile overload for file embedding #219

Closed PhilippMDoerner closed 8 months ago

PhilippMDoerner commented 8 months ago

This also adds an example.

Note: On my machine locally it was impossible to fully run nimble docs, even after running nimble docsDeps. Because it doesn't find the happyx custom block: /home/philipp/dev/nimib/docsrc/interactivity.nim(281, 5) Error: undeclared identifier: 'nbHappyxCode'.

This is caused by the when moduleAvailable(happyx) check failing because /home/philipp/.nimble/pkgs2/happyx-3.0.0-09a3bb3a93ddca05b973235465eb1f2c6414d5b8/happyx/spa/tag.nim(216, 8) Error: undeclared identifier: 're2'.

I assume that's a happyx problem.

pietroppeter commented 8 months ago

for ref on this, see the discussion we had here, in particular the linked comment: https://github.com/pietroppeter/nimibook/issues/85#issuecomment-1784153469

will wait for preview to build and check

will also look to open an issue about the happy problem for documents

thanks for working on this!

PhilippMDoerner commented 8 months ago

Checks passed!

Regarding the issue, appears I read your comment too late, I already opened https://github.com/HapticX/happyx/issues/170 :sweat_smile:

Ethosa commented 8 months ago

/home/philipp/.nimble/pkgs2/happyx-3.0.0-09a3bb3a93ddca05b973235465eb1f2c6414d5b8/happyx/spa/tag.nim(216, 8) Error: undeclared identifier: 're2'.

@PhilippMDoerner please delete all versions of regex package and install #head version. This should help. image

pietroppeter commented 8 months ago

yep, indeed the preview works fine! (if you look at the last check you will see there is a netlify preview and clicking on details let you look at built docs):

image

regarding happyx, actually happy that you went and opened the issue, I thought it was an issue with nimib.

thanks and have a great day (or likely great night)!

pietroppeter commented 8 months ago

btw, note that LICENSE is bizarrely highlighted (I guess by highlight.js) by mistake...