add netlify preview to CI

[pietroppeter]

instructions taken from: https://github.com/pietroppeter/nimib/issues/71

requirements:

• netlify account with NETLIFY_AUTH_TOKEN, NETLIFY_SITE_ID

• [x] sign up to netlify with github

• [x] connect a repo to deploy: nimib

• [x] set publish directory to docs/

• [x] generate access token NETLIFY_AUTH_TOKEN using this link, taken in deploy action used

• [x] get NETLIFY_SITE_ID from Site Settings in Netlify

• [x] add and adapt ymls to PR

  • [x] netlify_pr_task
  • [x] netlify_build_docs
  • [x] netlify_deploy_preview

[netlify[bot]]

✅ Deploy Preview for nimib ready!

Name	Link
🔨 Latest commit	00491106bee67219499d5ab3d9898e94bb76c22f
🔍 Latest deploy log	https://app.netlify.com/sites/nimib/deploys/62b8d01093baba000871250a
😎 Deploy Preview	https://deploy-preview-92--nimib.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[pietroppeter]

it seems it is not working, I was (naively) expecting to have a working deploy preview. GitHub does not seem to see/execute neither netlify_pr_task and netlify_deploy_preview.

@HugoGranstrom can you give a look and see if you manage to understand what is not going fine? I did follow the advice you gave, only did some renaming of the yml (valid -> netlify_build_docs, pr_tasks -> netlify_pr_task, pr_preview -> netlify_deploy_preview).

[HugoGranstrom]

I checked the code quickly on my phone but I can't seem to find any obvious error why they wouldn't even run. So I think it is a Github security thing that if you add CI files in a PR they won't be run (just imagine if anyone could run whatever they wanted on your CI). So what I would do is to merge this and open a new PR and see if they are running there. Then these new CI files should be able to run

[pietroppeter]

Make sense, will do!