create issues from features in mdbook not in nimibook

pietroppeter / nimibook

A port of mdbook to nim(ib)

https://pietroppeter.github.io/nimibook/

MIT License

78 stars 7 forks source link

create issues from features in mdbook not in nimibook #9

Open pietroppeter opened 3 years ago

pietroppeter commented 3 years ago

we should map all features that are present in mdbook and not here in appropriate issues.

besides looking at mdbook documentation, an useful list to start with is contained in the html comment hidden in README.md (written while converting index.hbs to mustache).

pietroppeter commented 3 years ago

check below after opening issue with ideas about api/implementation:

[ ] support `SUMMARY.md, see #62
[x] book.toml fixed in #50
[x] next/previous, fixed in #28
[x] ~mathjax_support~ added support for latex in #50 (we have not removed the mathjax part of template, so technically it is still available
[ ] is_print/print_enable
[ ] additional_css/additional_js (probably we do not need to do anything, just check it works and maybe escape the mustache variable...)
[ ] base_url
[ ] git_repository_edit_url
[ ] favicon_svg/favicon_png
[ ] search_enable/search_js
[ ] google_analytics
[ ] livereload (needs a cli serve functionality)

playground stuff is probably not relevant (since it is rust specific).

HugoGranstrom commented 3 years ago

mathjax_support (I would go with katex as in nimib? )

I have no preference in either way really, I just want Latex rendering to work 😛 Just to get it working, would you be ok with adding this so nbDoc.useLatex works at least?

        {{#latex}}
        <!-- MathJax -->
        <script async type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/mathjax/2.7.1/MathJax.js?config=TeX-AMS-MML_HTMLorMML"></script>
        {{/latex}}

pietroppeter commented 3 years ago

Well, already now without changing anything in nimibook using

nbDoc.context["mathjax_support"] = true

Should make latex work (with mathjax).

To add latex with katex (should be faster than mathjax) and make nbDoc.useLatex work we would need to just add {{{latex}}} in document.mustache's head.

HugoGranstrom commented 3 years ago

Of course! The simple solution is too obvious sometimes 😅 Thank you! :)