pietrorampini / UpdateChecker

Increase your app's updates
Apache License 2.0
649 stars 126 forks source link

String in french translation invalidates XML #90

Closed WebnetMobile closed 10 years ago

WebnetMobile commented 10 years ago

It's

<string name="downloadFor">Vérification d'une nouvelle mise à jour pour %1$s!\nDisponible dès maintenant sur %2$s.</string>

while it lacks escaping in d'un as it should be

<string name="downloadFor">Vérification d\'une nouvelle mise à jour pour %1$s!\nDisponible dès maintenant sur %2$s.</string>
pietrorampini commented 10 years ago

The apostrophe is already present. See https://github.com/rampo/UpdateChecker/blob/master/library/src/main/res/values-fr/strings.xml

WebnetMobile commented 10 years ago

it is not present in recent stable - 2.1.0 -> https://github.com/rampo/UpdateChecker/releases/tag/v2.1.0 - so that release is faulty, and there's no 2.1.1 as far as I can see

pietrorampini commented 10 years ago

You're right. I'll release 2.1.1 fixing this.

pietrorampini commented 10 years ago

See release 2.1.1