Closed jrmhaig closed 10 years ago
is it about the memory leaks in use of event listener? then i will try it out
I don't know anything about memory leaks so I cannot say whether or not it fixes any. I am more interested in being able to change the functions of the buttons.
Specifically, this is to address issue #10. Should I have raised this pull requests in a way to link to that issue directly?
Your code checks out, but we need to update version numbers and the change log before we can merge it to master. Can you please request to merge this to testing, not master. Thank you :)
OK. Closing this to re-open as a pull to testing.
I have done a little bit of testing of this but it probably needs a bit of a review to make sure that it doesn't break things.