piface / pifacecommon

Common functions for interacting with PiFace products
GNU General Public License v3.0
42 stars 31 forks source link

Add deregister function to PortEventListener #11

Closed jrmhaig closed 10 years ago

jrmhaig commented 10 years ago

I have done a little bit of testing of this but it probably needs a bit of a review to make sure that it doesn't break things.

mpruessmeier commented 10 years ago

is it about the memory leaks in use of event listener? then i will try it out

jrmhaig commented 10 years ago

I don't know anything about memory leaks so I cannot say whether or not it fixes any. I am more interested in being able to change the functions of the buttons.

jrmhaig commented 10 years ago

Specifically, this is to address issue #10. Should I have raised this pull requests in a way to link to that issue directly?

thomasmacpherson commented 10 years ago

Your code checks out, but we need to update version numbers and the change log before we can merge it to master. Can you please request to merge this to testing, not master. Thank you :)

jrmhaig commented 10 years ago

OK. Closing this to re-open as a pull to testing.