search

piface / pifacecommon

Common functions for interacting with PiFace products
GNU General Public License v3.0
42 stars 31 forks source link

Import of errno is needed #14

Closed bagguley closed 10 years ago

bagguley commented 10 years ago

I get this error from a keyboard interrupt:

File "/usr/lib/python2.7/dist-packages/pifacecommon/interrupts.py", line 265, in watch_port_events if e.errno != errno.EINTR: NameError: global name 'errno' is not defined

The import of errno is missing from interrupts.py

tompreston commented 10 years ago

Fixed in v4.0.1.

bagguley commented 10 years ago

Actually it would be good if it handled a control C and stopped all listeners. On 3 Mar 2014 10:07, "Thomas Preston" notifications@github.com wrote:

Fixed in v4.0.1.

— Reply to this email directly or view it on GitHubhttps://github.com/piface/pifacecommon/issues/14#issuecomment-36496080 .

tompreston commented 10 years ago

I'm really unhappy with the current handling of Ctrl+C. I'm not sure on stopping all listeners, I'd prefer something more generic so that people can choose what happens on Ctrl+C.

Any ideas?

bagguley commented 10 years ago

Yeah, it needs some kind of callback I guess.

On 3 March 2014 10:38, Thomas Preston notifications@github.com wrote:

I'm really unhappy with the current handling of Ctrl+C. I'm not sure on stopping all listeners, I'd prefer something more generic so that people can choose what happens on Ctrl+C.

Any ideas?

— Reply to this email directly or view it on GitHubhttps://github.com/piface/pifacecommon/issues/14#issuecomment-36498276 .