search

pifou25 / Thinq-MQTT-Proxy

LGThinq v2 API via MQTT
Apache License 2.0
0 stars 3 forks source link

Docker container #1

Closed dkneisz closed 2 years ago

dkneisz commented 2 years ago

I fixed your dockerfile to create a working docker image. I used most of the work you've done, but you forgot to copy some parts of the app. Therefore it could not build successfully. I also added a section to readme.md on how to use it. I simply built the app and let it run with "init" to get a state.json, that I then used for my container.

dkneisz commented 2 years ago

Sorry, I just noticed that my changes to dockerhub.yml are included here. I suggest you change this because you are trying to push the docker container to my dockerhub. I also made some other changes to dockerhub.yml (e.g. pushing with a tag). If you are interested in that please have a look at https://github.com/dkneisz/Thinq-MQTT-Proxy/blob/master/.github/workflows/dockerhub.yml.

pifou25 commented 2 years ago

fixed, thanks you, I dont use tags, didnt understand the yaml extra config...

dkneisz commented 2 years ago

The extra config is just to push the container to /thinq2mqtt:master if you push something to master. If you add a tag to your github (e.g. "v1.0.0") then the container is pushed to /think2mqtt: and /thinq2mqtt:latest. This is userful when you add some functionality to still have access to older versions. I also added some caching (that was suggested in the docs).