search

piggz / harbour-amazfish

Amazfit Bip support for SailfishOS
GNU General Public License v3.0
103 stars 51 forks source link

Separte device specific implementations per device generation type #258

Open Thaodan opened 1 year ago

Thaodan commented 1 year ago

Similar as done in Gadget bridge features such as notifications should be separated where possible. For example right now the notification logic is specific to the first generation gadget bridge.

I saw some effort doing this already however I'm not sure if there was a generic bug for this topic.

piggz commented 1 year ago

This sort-of exists already using the class hierarchy and overriding of methods. Later devices have certain features overridden. The current hierarchy is basically GTR2 > GTS2 > GTS > Bip

Happy to accepts code-cleanups :)