piggz / harbour-amazfish

Amazfit Bip support for SailfishOS
GNU General Public License v3.0
103 stars 51 forks source link

Send title separated by 0x00 from rest of notifications #275

Closed jmlich closed 11 months ago

jmlich commented 11 months ago

amazfish introduced configurable separator in February 2021 https://github.com/piggz/harbour-amazfish/commit/0638cc79c93682ea88721bf402324995775ba48f

infinitime introduced 0x00 separator for notification content in April 2021 https://github.com/InfiniTimeOrg/InfiniTime/commit/03de1c67393fcb99b5987514be6f470349c57c0f

Using 0x00 separator will improve layout notifications in PineTime. See screenshots.

image20231008_133151313 image20231008_133158210

jmlich commented 11 months ago

p.s. it would be great to add #hacktoberfest topic to the project

piggz commented 11 months ago

Youll have to explain to me what adding #hacktoberfest will do :)

jmlich commented 11 months ago

There is an web site about that https://hacktoberfest.com/

Basically, every merged merge request counts to competition. After 3 accepted merge requests I will get an reward. This year the reward is planted tree in my name.

piggz commented 11 months ago

Sounds like a good enough reason!