piggz / harbour-amazfish

Amazfit Bip support for SailfishOS
GNU General Public License v3.0
103 stars 51 forks source link

Return back to rootPage after pairing, busy indicator centered #293

Closed jmlich closed 10 months ago

jmlich commented 10 months ago

The test case is following: User tries to cancel old pairing and to pair new smartwatch

Explanation: The DialogPL implements onAccepted method. The method it self performs app.pages.pop(), then unpairAccepted() is invoked and calls app.pages.replace(PairSelectDeviceType). The consequence is that the FirstPage is disposed and app.rootPage is set to null.

I am not 100% sure if this behaves same with all UI flavors. My best guess is that is this is that yes. The code shows that kirigami, uuitk, and qtcontrols implementation does .pop() it self.

I have also included some tiny fixes I believe should work the same on all platfroms