piggz / harbour-amazfish

Amazfit Bip support for SailfishOS
GNU General Public License v3.0
103 stars 51 forks source link

Single menu item must have icon in Ubuntu Touch #295

Closed jmlich closed 10 months ago

jmlich commented 10 months ago

The menus in ubuntu touch containing only one item collapses into action button without label. The button is not visible without icon.

For example the refresh MenuItem on DebugInfo Page looks like this after changed:

screenshot20231023_074917750

Additionally, the iconSource in PageMenuItemPL.qml must be done other way around in order to work at least with current release with Ubuntu Touch.

The icons are set in order to keep working SailfishOS port even when the icon is not set. This is a case of following icons

    property string iconStravaLogin: "image://theme/user-admin"
    property string iconUploadToStrava: "image://theme/share"
    property string iconDownloadData: "image://theme/transfer-progress-download"

The only MenuItem which will be different on all 4 flavors is refresh item on DebugInfo Page, because refresh icon already exists in Styler component.