piggz / harbour-amazfish

Amazfit Bip support for SailfishOS
GNU General Public License v3.0
103 stars 51 forks source link

Battery log stored in generic table #309

Closed jmlich closed 8 months ago

jmlich commented 10 months ago

The main difference against https://github.com/piggz/harbour-amazfish/pull/273 is storing both key and value.

There are still some questions:

jmlich commented 10 months ago

btw I don't like redundancy of Info enum

https://github.com/piggz/harbour-amazfish/blob/cf13e026b15806b2b1ad55375e831f9bdee41ae5/lib/src/amazfish.h#L46-L60 https://github.com/piggz/harbour-amazfish/blob/cf13e026b15806b2b1ad55375e831f9bdee41ae5/daemon/src/devices/abstractdevice.h#L27-L40

piggz commented 10 months ago

Yeah, i think there was a reason for that, but it escapes me now!

jmlich commented 9 months ago

The issue with redundant enum isn't something I wanted to address in this pull request. It was mentioned just out of curiosity.