piggz / harbour-amazfish

Amazfit Bip support for SailfishOS
GNU General Public License v3.0
103 stars 52 forks source link

Missing icons for sport activities #371

Open jmlich opened 4 months ago

jmlich commented 4 months ago

I have seen following error message in logs:

May 10 18:01:21 ubuntu-phablet aa-exec[117594]: file:///usr/lib/aarch64-linux-gnu/qt5/qml/Lomiri/Components/1.3/Icon.qml:115:5: QML Image: Cannot open: file:///opt/click.ubuntu.com/uk.co.piggz.amazfish/2.2.6/share/harbour-amazfish-ui/qml/pics/custom-icons/icon-m-activity.png

It is not obvious, but the icon is loaded at

https://github.com/piggz/harbour-amazfish/blob/62460cc97b4308f3908de33489e14af0322b146e/ui/qml/pages/SportsSummaryPage.qml#L32

The kind string (taken from sports_data database table) is converted from number to string at https://github.com/piggz/harbour-amazfish/blob/62460cc97b4308f3908de33489e14af0322b146e/lib/src/amazfish.cpp#L3

Every activity kind should have own icon in https://github.com/piggz/harbour-amazfish/tree/master/ui/qml/custom-icons, but it seems following icons are missing:

icon-m-notmeasured.png
icon-m-activity.png
icon-m-lightsleep.png
icon-m-deepsleep.png
icon-m-notworn.png
icon-m-exercise.png
icon-m-eliptical trainer.png
icon-m-jump rope.png
icon-m-yoga.png