search

piggz / harbour-shutter

GNU General Public License v2.0
15 stars 8 forks source link

Make face detection optional #12

Closed SumwunDucainest closed 8 months ago

SumwunDucainest commented 8 months ago

The current implementation of face detection is WIP, which can lead to a distracting rectangle in the ViewFinder. This commit makes that feature optional at compile time using #defines and disables it by default. It can be enabled by adding FACE_DETECTION to DEFINES in harbour-shutter.pro.

piggz commented 8 months ago

Thanks .. great to have more contributions.

For this one, I wonder if we could just make it a user-configurable option, and always compile it in? Would sit nicely in the settings panel im sure.

SumwunDucainest commented 8 months ago

I was considering the same thing, but I haven't taken the time to look into enabling/disabling it at runtime or where the settings panel is in the code.

Guess I have some homework to do!