search

pigoz / mpv-nihongo

🇯🇵 mpv scripts to optimize language learning through immersion
15 stars 3 forks source link

jplookup crashes if ~/mpv-blacklist.txt is not present #9

Closed leovilok closed 4 years ago

leovilok commented 4 years ago

I think that this line is supposed to prevent that: https://github.com/pigoz/mpv-nihongo/blob/ec77ca1ed9158aa45f62ff98a90357ec8c5ac280/src/blacklist.ts#L12

But when ~/mpv-blacklist.txt does not exist, jslookup.js crashes, leaving this in mpv log:

[jplookup] Error: cannot open file: '/home/leo/mpv-blacklist.txt'
[jplookup]      at read_file (native)
[jplookup]      at /home/leo/.config/mpv/scripts/jplookup.js:6
[jplookup]      at Function.prototype.call (native)
[jplookup]      at u (/home/leo/.config/mpv/scripts/jplookup.js:1)
[jplookup]      at p (/home/leo/.config/mpv/scripts/jplookup.js:1)
[jplookup]      at /home/leo/.config/mpv/scripts/jplookup.js:12
[jplookup]      at Function.prototype.call (native)
[jplookup]      at u (/home/leo/.config/mpv/scripts/jplookup.js:1)
[jplookup]      at /home/leo/.config/mpv/scripts/jplookup.js:1
[jplookup]      at /home/leo/.config/mpv/scripts/jplookup.js:13
[jplookup]      at run_script (native)
[jplookup] Could not load javascript /home/leo/.config/mpv/scripts/jplookup.js

(Of course, a workaround is to touch ~/mpv-blacklist.txt)