search

pigskin / kodi-gamepass

NFL Game Pass add-on for Kodi
Other
122 stars 83 forks source link

Support condensed game streams #22

Closed Vulpecula-nl closed 11 years ago

Vulpecula-nl commented 11 years ago

I have found the url for the condensed game plays. Look at the following urls

Baltimore Ravens @ Denver Broncos: http://nlds133.cdnak.neulion.com/nlds_vod/nfl/vod/2013/09/05/55837/2_55837_bal_den_2013_h_snap2w_1_4500.mp4 Miami Dolphins @ Cleveland Browns: http://nlds84.cdnak.neulion.com/nlds_vod/nfl/vod/2013/09/08/55841/2_55841_mia_cle_2013_h_snap2w_1_4500.mp4

Does this help you to adjust the addon?

divingmule commented 11 years ago

Actually in the games dict there is a key something like 'condensed_id', I think* if we resolve the url with this id it should work.

The question is, how do we implement it? My first thoughts are to add a context menu item or an add-on setting.

msoderberg commented 11 years ago

What do you think of each game having it's own folder under / which contains both the full game and the condensed version?

Example: 2013/Week 1/Baltimore Ravens at Denver Broncos/Full Game 2013/Week 1/Baltimore Ravens at Denver Broncos/Condensed Game

divingmule commented 11 years ago

It's been my experience that most users don't want to have to make another choice, less clicks is better.

I'm leaning towards doing a setting, something like "full version | condensed | ask" where ask would open a select dialog to let you choose each time much like you describe above.

On Thu, Sep 12, 2013 at 3:35 PM, msoderberg notifications@github.comwrote:

What do you think of each game having it's own folder under / which contains both the full game and the condensed version?

Example: 2013/Week 1/Baltimore Ravens at Denver Broncos/Full Game 2013/Week 1/Baltimore Ravens at Denver Broncos/Condensed Game

— Reply to this email directly or view it on GitHubhttps://github.com/Alexqw/xbmc-gamepass/issues/22#issuecomment-24353601 .

msoderberg commented 11 years ago

Yes that sounds like a better idea! And only open the dialogue if the stream exists maybe, it took a couple of hours before the condensed versions were available after the games finished last sunday.

aqw commented 11 years ago

I agree with divingmule. "full version | condensed | ask" and make "full version" the default.

The only concern I have with this is making sure we avoid "condensed" for live streams, since they don't exist.

---Alex

aqw commented 11 years ago

Updated the issue title to reflect the issue.

---Alex

aqw commented 11 years ago

Feature implemented by msoderberg. Pull the latest to get enjoy condensed games. Be sure to go into settings to set the preference.

---Alex