Game Pass Domestic mode incorrectly limits access to the NFL Network section

[sdstreams]

The NFL Network tab now does not work it doesn't display any info that has been there for the last year.. Noticed it does not let me choose domestic or international in settings as well anymore?

Update: realized with your update you added the auto detect sub which killed the cool function for us Domestic users being able to just select International and allowing us the benefits of the NFL Network tab that international users had. If that was intended no problem.

[aqw]

@HenioH did you update from version 0.9.1 or something a bit earlier? The code for acquiring the NFL Network shows was significantly changed between 0.9.0 and 0.9.1, but was left unchanged in 0.9.2. In any case, please restart Kodi, enable debugging in both Kodi and the addon, and provide the log here.

As for the removal of the domestic vs international setting, that's because there's no need any longer; it's auto-detected now. From how we understand how Game Pass's auth works, a domestic account cannot successfully authenticate to the international servers (nor vice versa). The Game Pass server response provides info as to whether they detect you're 'domestic' or not, so we just rolled the setting into an auto-detect feature for that response.

---Alex

[sdstreams]

The prior 0.9.1 and previous versions allowed domestic users to go into settings and select international which allowed us to use the live NFL Network features which otherwise would be blocked for domestic users. As of now with the auto detect it kills the benefit for the Domestic users to select International manually and use the benefits under the NFL Network tab. True you cant use the live game functions under the Gamepass tab for Domestic users even if you manually selected International but it did allow us Domestic users the NFL Network live and content under that tab. So that feature glitch is no longer since we cant manually select between domestic and international :( I will be staying on the 0.9.1 as it allows those benefits still. Just a little heads up for Domestic users if you'd like to continue using the NFL Network tab features.

[aqw]

@HenioH Where are you located geographically? And which features could you previously access that you no longer can?

What you're telling me surprises me, as we have many logs from users in the US that tells a different story.

---Alex

[sdstreams]

I live in California USA. I understand as a domestic user I was not allowed to watch the games live under the Gamepass Tab. That will always be the case having a domestic subscription. In the prior versions from 0.9.1 and under we had the option to select Domestic or International in the settings. When Domestic was choosen the NFL Network Tab features did not function like the Live NFL Network, Redzone Archives, Hard Knocks, Game Day, Etc...But when you manually select International in the settings it allowed those features to function even if you had a Domestic account under the NFL Network tab...of course this is all without any proxy setup. With the auto detect it automatically selects Domestic which then kills the NFL Network tab features. Could've been a glitch that allowed Domestic user to access those features but was a huge benefit of being able to select International while still having a Domestic Subscription. You have to also exit the addon every time you switched between Domestic or International to have changes take affect.

[aqw]

@HenioH Ahh, I understand now.

So, just to be clear, you could not ever watch "live" games yes? But the problem now is that quite a few things in the UI are hidden, such as NFL Network, the shows, etc.

This might be a leftover from the old NFL Game Rewind days (the precursor to Game Pass Domestic) when the service didn't offer those features and so hid them in UI. I'll take a look at the code, perhaps it's as simple as unhiding them.

---Alex

[aqw]

@HenioH I can't test this, as I'm not in the US, but try changing line 442 in default.py from:

if gpr.subscription == 'international':

to

if True

You'll need to exit the addon and re-enter it after the change is made. Let me know how that works out for you.

---Alex

[sdstreams]

Yes exactly.. That would greatly appreciated as those extra options from having such a restricted Domestic Subscriptions was a huge benefit. I was looking at the code in default last night couldnt figure out what line it was to change.

So I changed line 442 in default.py

if gpr.subscription == 'international':

to

if True

and that seems to work now. When I click on the NFL Network tab all the content under there opens up exactly how it did in the previous versions even if signed into a Domestic Subscription. I can watch the NFL Network live, Hall of Fame, Hard Knocks, NFL Total Access, Etc... Thanks for the help!

[aqw]

@HenioH Excellent. I'll likely get around to committing this fix on Monday.

Thanks for taking the time to report this bug. Game Pass Domestic users are rare around here, so your feedback is quite valuable.

---Alex

[sdstreams]

No problem glad to help in anyway possible.

[ghost]

Is it possible to have the option of turning off auto detection and have the option of manually selecting domestic or international. Thanks

[aqw]

@sportshd With the fix above, there is no need for manually selecting.

---Alex

[ghost]

I made the change my line 442 looks like this if True == 'international':

I am still getting nothing when I click on NFL Network.

[sdstreams]

it should be

if True

that's it nothing else in that line just those two words

[ghost]

I made the change saved it and started kodi again and now the addon doesn't launch any more.

I am on windows 10 jarvis 16.1

[aqw]

@sportshd You likely edited it incorrectly. Either wait until Monday when I make the change and commit it, or double check that file and make sure it is exactly as stated above. Specifically, make sure the indentation matches what the original had (indentation is meaningful in Python).

---Alex

[ghost]

Ok thanks, I think it would be nice to be able to disable the auto detect feature and let us choose between domestic and international. I think the domestic users would agree.

[aqw]

@sportshd I am open to bringing back the setting to choose which subscription type /if/ indeed it turns out it would actually do something. ;-)

As of now, I'm unconvinced and I believe the code is working as intended. I've pushed the change that fixed the original problem in this issue. We'll wait a few days, and see if that resolves people's perceived problems.

---Alex